fix(raiko): avoid duplicate image uploads #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smtmfft <[email protected]>
johntaiko
approved these changes
Dec 24, 2024
keroro520
reviewed
Dec 24, 2024
keroro520
requested changes
Dec 24, 2024
|
Oh, yes, risc0 checked the image id. I update sp1 logic and thought the risc0 maybe the same. |
Signed-off-by: smtmfft <[email protected]>
|
seems sp1 can not easily bypass the upload, although only optimizing the setup part makes the process slightly better. |
succinctlabs/sp1#1875 implement the v2 sdk, which gracefully handle the image upload: We can switch to the new version of SDK once it becomes stable. @smtmfft |
|
cool, so far we rely on their network service, let's see when they will update the service, probably in 4.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block proof ELF is approximately 8 MB, and is being uploaded every time. Using an initialization-once approach to avoid redundant uploads