Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(host): impl API "/admin/pause" #440

Merged
merged 1 commit into from
Dec 27, 2024
Merged

feat(host): impl API "/admin/pause" #440

merged 1 commit into from
Dec 27, 2024

Conversation

keroro520
Copy link
Contributor

@keroro520 keroro520 commented Dec 24, 2024 •
edited
Loading

Add HTTP API "/admin/pause".

Clear pending tasks and cancel all running tasks and aggregation tasks when "/admin/pause" called.

  • Add HTTP endpoint "/admin/pause" and "/admin/unpause"
  • Add a pause flag Prover.pause_flag
  • Handle pause message inside ProofActor
  • Add tests covered HTTP endpoint "/admin/pause"
  • Add tests covered ProofActor.handle_system_pause()
  • Reject request if pause flag is true

TODOs in the future:

smtmfft
smtmfft approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@smtmfft smtmfft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

host/src/interfaces.rs Show resolved Hide resolved
host/src/proof.rs Show resolved Hide resolved
host/src/server/api/admin.rs Show resolved Hide resolved
@keroro520 keroro520 added this pull request to the merge queue Dec 27, 2024
Merged via the queue into taikoxyz:main with commit ddba6b0 Dec 27, 2024
11 checks passed
@keroro520 keroro520 deleted the feat-admin-pause branch December 27, 2024 09:13
@taiko-kitty taiko-kitty mentioned this pull request Dec 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smtmfft smtmfft smtmfft approved these changes

@johntaiko johntaiko Awaiting requested review from johntaiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keroro520 @smtmfft