Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add task image id #442

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

feat: add task image id #442

wants to merge 32 commits into from

Conversation

keroro520
Copy link
Contributor

No description provided.

@keroro520 keroro520 requested a review from smtmfft January 6, 2025 03:10
smtmfft
smtmfft approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@smtmfft smtmfft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CI & merge it.

@keroro520
Copy link
Contributor Author

Fix CI & merge it.

Yes. I am making another PR to fix the CI. The CI failure is not associated to this PR.

keroro520 added 21 commits January 7, 2025 13:33
@keroro520
feat(taskdb): remove get_task_manager
f5225ca
@keroro520
fix: resolve compilation errors and update test cases for image_id field
9904017
@keroro520
feat: add image_id field to ProofRequest and ProofRequestOpt
8717a8e
@keroro520
feat: implement image id retrieval from environment variables
11a8f8b
@keroro520
feat: add image_id field to AggregationRequest and update related imp…
3fcfc5b 
…lementations
@keroro520
feat: add error handling for missing image IDs
af1df52
@keroro520
chore: minor modification
587fcee
@keroro520
refactor: replace From implementation with new constructor for ProofT…
bc767e7 
…askDescriptor
@keroro520
refactor: simplify ProofTaskDescriptor constructor with unified new f…
95fb714 
…unction
@keroro520
refactor: update ProofTaskDescriptor usage to use new constructor
c43ff1b
@keroro520
refactor: simplify ProofTaskDescriptor constructor and remove From tr…
72104cc 
…ait implementation
@keroro520
refactor: update all ProofTaskDescriptor::from usages to use new cons…
1c26e95 
…tructor
@keroro520
fix: add image_id field to AggregationOnlyRequest initialization
d7f2161
@keroro520
refactor: implement TryFrom(AggregationOnlyRequest) for AggregationTa…
50168fc 
…skDescriptor
@keroro520
fix: throw error of missing image_id
e56cb34
@keroro520
feat: add ensure_ensure_proof_request_image_id, ensure_aggregation_re…
f600130 
…quest_image_id
@keroro520
feat(lib): add Prover::{current_proving_image(), current_aggregation_…
5c7dcea 
…image()} methods
@keroro520
chore: fix TryInto call
76912e4
@keroro520
refactor: derive Default for ProofTaskDescriptor
3220790
@keroro520
feat(core): add get_proving_image/get_aggregation_image by proof_type
da7928e
@keroro520
chore: fix clippy warning
0538053
@keroro520 keroro520 force-pushed the feat-task-image-id branch 2 times, most recently from dc7ab8b to a9c3fdf Compare January 7, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smtmfft smtmfft smtmfft approved these changes

@johntaiko johntaiko Awaiting requested review from johntaiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keroro520 @smtmfft