Update risc0 prover to use k256 and keccak acceleration #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't extensively benchmarked against a lot of blocks, but shaves off most cycles in the ones I have.
A subtle change that might be missed is that I switched the keccak impl in this repo to use alloy-primitives (which internally is k256) from sha3 to optimize for our use case. It is the only change that might have some impact on other provers, but also didn't make sense to me why three different implementations of secp256k1 were being used. Happy to revert that or put it behind a feature flag/cfg that's only used in our prover impl if preferred.
Pointing at this PR of reth to enable k256 taikoxyz/taiko-reth#62