Fix Nginx Bottlenecks (#28)

* drop access logs * Update performance results in README.md * update benchmark.graphql * Update performance results in README.md * update benchmark.graphql * update nginx worker process * Update performance results in README.md * chore: update benchmarking group --------- Co-authored-by: tusharmath <[email protected]>
tailcallhq · Nov 25, 2023 · ebe600e · ebe600e
1 parent b2f7267
commit ebe600e
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 21 deletions.
diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml
@@ -1,4 +1,4 @@
-name: 'Run benchmark'
+name: "Run benchmark"
 
 on:
   pull_request:
@@ -14,7 +14,6 @@ jobs:
     runs-on: benchmarking-runner
     if: github.event.head_commit.message != 'Update performance results in README.md'
     steps:
-
       - name: Checkout (GitHub)
         uses: actions/checkout@v4
         with:

diff --git a/README.md b/README.md
@@ -46,11 +46,11 @@ Get started with the benchmarks:
 
 | Server | Requests/sec | Latency (ms) |
 |--------:|--------------:|--------------:|
-| [Tailcall] | `7,098.02` | `14.05` |
-| [Caliban] | `6,428.14` | `15.66` |
-| [Gqlgen] | `2,147.01` | `48.48` |
-| [Apollo GraphQL] | `1,759.84` | `56.65` |
-| [Netflix DGS] | `1,455.06` | `88.90` |
+| [Tailcall] | `20,349.70` | `4.90` |
+| [Gqlgen] | `15,184.20` | `8.41` |
+| [Caliban] | `10,570.30` | `9.51` |
+| [Apollo GraphQL] | `3,934.92` | `25.52` |
+| [Netflix DGS] | `353.93` | `278.14` |
 
 <!-- PERFORMANCE_RESULTS_END -->
 

diff --git a/assets/latency_histogram.png b/assets/latency_histogram.png
diff --git a/assets/req_sec_histogram.png b/assets/req_sec_histogram.png
diff --git a/graphql/tailcall/benchmark.graphql b/graphql/tailcall/benchmark.graphql
@@ -1,16 +1,11 @@
 schema
-@server(
-  port: 8000
-  enableGraphiql: true
-  enableQueryValidation: false
-  workers: 16
-) @upstream(
-  baseURL: "http://jsonplaceholder.typicode.com"
-  enableHttpCache: false
-  poolMaxIdlePerHost: 200
-  tcpKeepAlive: 60
-  proxy: {url: "http://127.0.0.1:3000"}
-){
+  @server(port: 8000, enableGraphiql: true, enableQueryValidation: false)
+  @upstream(
+    baseURL: "http://jsonplaceholder.typicode.com"
+    poolMaxIdlePerHost: 200
+    tcpKeepAlive: 60
+    proxy: { url: "http://127.0.0.1:3000" }
+  ) {
   query: Query
 }
 

diff --git a/nginx/nginx.conf b/nginx/nginx.conf
@@ -1,5 +1,5 @@
 pid /tmp/nginx.pid;
-worker_processes 1;
+worker_processes auto;
 
 events {
     worker_connections 512;
@@ -8,7 +8,6 @@ events {
 error_log /tmp/error.log error;
 
 http {
-    access_log /tmp/access.log;
     proxy_cache_path /tmp/nginx-cache levels=1:2 keys_zone=http_cache:10m max_size=1g inactive=60m use_temp_path=on;
     client_body_temp_path /tmp/nginx-client-body;
     proxy_temp_path /tmp/nginx-proxy;

diff --git a/nginx/run.sh b/nginx/run.sh