Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate pdf for slides #4

Closed
wants to merge 7 commits into from
Closed

Conversation

neo773
Copy link

@neo773 neo773 commented Sep 15, 2024

Utilizes Puppeteer to generate precisely dimensioned PDFs, eliminating top and bottom whitespace.

Performance comparison:

  • This solution: 5.7 seconds
  • decktape library: 80 seconds
  • Result: 14x performance improvement

Execution times:

node gen-pdf.js 3.11s user 1.80s system 85% cpu 5.768 total
npx -y decktape remark http://127.0.0.1:8080/ slides.pdf 11.11s user 6.57s system 21% cpu 1:20.71 total

Sample PDF output

Successful CI Run

a.mp4

/claim #1
/closes #1

@neo773 neo773 changed the title feat: generate pdfs for slides feat: generate pdf for slides Sep 15, 2024
@tusharmath
Copy link
Collaborator

Color and theming isn't right.

@neo773
Copy link
Author

neo773 commented Sep 16, 2024

Fixed the issues.
Also updated CI runner to run on macOS this ensures accurate rendering of the emojis as emojis on Linux are different.

@neo773
Copy link
Author

neo773 commented Sep 16, 2024

Please use Chrome's PDF viewer to open this, macOS's built-in PDF viewer has some issues with emojis.

slides.pdf

@tusharmath
Copy link
Collaborator

@neo773 Some emoji's are visible some are not on mac. I think overall its going in the right direction.

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

@tusharmath tusharmath marked this pull request as draft September 16, 2024 14:34
@neo773 neo773 marked this pull request as ready for review September 16, 2024 15:26
@neo773
Copy link
Author

neo773 commented Sep 16, 2024

slides.pdf

docs/slides.md Outdated Show resolved Hide resolved
@neo773 neo773 closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto generate PDF for the slides
2 participants