Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add query complexity and depth support in server directive #2828

Closed
wants to merge 34 commits into from
Closed

feat: add query complexity and depth support in server directive #2828

wants to merge 34 commits into from

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented Sep 16, 2024 •
edited
Loading

Summary:
documentation update pull request: tailcallhq/tailcallhq.github.io#492

Issue Reference(s):
Fixes #2725

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@laststylebender14 laststylebender14 marked this pull request as draft September 16, 2024 08:51
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Sep 16, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base (87c4c7c) to head (5cd51b8).
Report is 222 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2828      +/-   ##
==========================================
+ Coverage   87.13%   87.27%   +0.14%     
==========================================
  Files         254      257       +3     
  Lines       25144    25343     +199     
==========================================
+ Hits        21910    22119     +209     
+ Misses       3234     3224      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

laststylebender14 and others added 21 commits September 16, 2024 14:44
@laststylebender14
- used associated types
48f2e4e
@laststylebender14
- added test cases
bbdcb49
@laststylebender14
- fix the Value to ConstValue
2adc5f4
@laststylebender14
- fix constvalue and value issue.
d756b26
@laststylebender14
- take query complexity and depth from server directive.
3aa2424
@laststylebender14
- add when operator to rule
5db2d92
@laststylebender14
- apply rules conditionally.
8054dd9
@laststylebender14
- auto updated
72bb868
@laststylebender14
- updated snap: added server to index.
3fc1b4f
@laststylebender14
- made rules generic over T.
5ed4208
@laststylebender14
Merge branch 'main' into feat/add-query-complexity-and-depth
a864282
@laststylebender14
- added default to ensure only applied setting is executed.
f06a19d
@laststylebender14
- auto generated.
b5fd2cb
@laststylebender14
- updated error msg.
ff3844f
@laststylebender14
- apply setting only when flag is true.
c9d3518
@laststylebender14
- lint fixes
d335da0
@laststylebender14
Merge branch 'main' into feat/add-query-complexity-and-depth
6ed10b6
@laststylebender14
- rename trait to ExecutionRule
03ce3f4
@laststylebender14
- fix ci tests.
1969d62
@laststylebender14
- lint fixes
80c9965
@laststylebender14
- added integration test for query complexity
ebbd47f
tusharmath
tusharmath reviewed Sep 21, 2024
View reviewed changes
src/core/jit/builder.rs
.when(self.index.query_depth().is_some()),
)
.validate(&plan)
.to_result()?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Store the computed query depth in the plan. The builder should not fail if depth or complexity thresholds are exceeded.

tusharmath
tusharmath reviewed Sep 21, 2024
View reviewed changes
src/core/jit/rules/query_depth.rs
}
}

impl ExecutionRule for QueryDepth {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExecutionRule is basically Transform with Value = OperationPlan and Error = String. Let's reuse it here.

@tusharmath tusharmath marked this pull request as draft September 21, 2024 12:58
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 26, 2024
@laststylebender14 laststylebender14 removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 6, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 11, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 16, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 21, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 26, 2024
@github-actions GitHub Actions
Copy link

PR closed after 10 days of inactivity.

@github-actions github-actions bot closed this Nov 16, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 18, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

PR closed after 10 days of inactivity.

@github-actions github-actions bot closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath left review comments

Assignees
No one assigned
Labels
state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Query complexity and depth
2 participants
@laststylebender14 @tusharmath