Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy): add http and grpc proxy #2875

Closed
wants to merge 4 commits into from

Conversation

karatakis
Copy link
Collaborator

Summary:
allow proxy setting for @httpand @grpc directives

Issue Reference(s):
Fixes #2820

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added ci: benchmark Runs benchmarks type: feature Brand new functionality, features, pages, workflows, endpoints, etc. labels Sep 20, 2024
@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Sep 21, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 94.08284% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.16%. Comparing base (090b8b0) to head (9e401c9).
Report is 81 commits behind head on main.

Files with missing lines Patch % Lines
src/core/app_context.rs 68.75% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2875      +/-   ##
==========================================
- Coverage   87.30%   87.16%   -0.15%     
==========================================
  Files         254      253       -1     
  Lines       25311    25668     +357     
==========================================
+ Hits        22099    22374     +275     
- Misses       3212     3294      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🐰 Bencher Report

Branch2875/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
from_json_bench📈 view plot
🚷 view threshold
6,297,600.00
(+1.91%)
6,310,842.12
(99.79%)
group_by📈 view plot
🚷 view threshold
478.98
(-2.26%)
513.99
(93.19%)
input/args.missing📈 view plot
🚷 view threshold
25.88
(+0.93%)
27.74
(93.28%)
input/args.nested.existing📈 view plot
🚷 view threshold
46.03
(+1.19%)
48.33
(95.25%)
input/args.nested.missing📈 view plot
🚷 view threshold
38.66
(-0.08%)
40.87
(94.60%)
input/args.root📈 view plot
🚷 view threshold
43.17
(+4.34%)
45.05
(95.83%)
input/headers.existing📈 view plot
🚷 view threshold
33.01
(+4.54%)
34.09
(96.85%)
input/headers.missing📈 view plot
🚷 view threshold
31.84
(+3.89%)
33.45
(95.19%)
input/value.missing📈 view plot
🚷 view threshold
23.42
(+0.13%)
24.68
(94.90%)
input/value.nested.existing📈 view plot
🚷 view threshold
42.92
(-0.43%)
45.77
(93.77%)
input/value.nested.missing📈 view plot
🚷 view threshold
36.82
(+0.51%)
38.55
(95.50%)
input/value.root📈 view plot
🚷 view threshold
41.22
(+6.48%)
41.65
(98.97%)
input/vars.existing📈 view plot
🚷 view threshold
8.44
(+1.61%)
9.55
(88.40%)
input/vars.missing📈 view plot
🚷 view threshold
8.88
(-1.27%)
11.77
(75.44%)
synth_nested📈 view plot
🚷 view threshold
138,110.00
(+23.36%)
174,540.98
(79.13%)
synth_nested_borrow📈 view plot
🚷 view threshold
80,107.00
(+55.70%)
102,872.58
(77.87%)
test_batched_body📈 view plot
🚷 view threshold
1,893.70
(-2.50%)
2,079.66
(91.06%)
test_batched_body #2📈 view plot
🚷 view threshold
1,517,600.00
(-4.09%)
1,728,414.67
(87.80%)
test_data_loader📈 view plot
🚷 view threshold
404,020.00
(-1.03%)
458,138.25
(88.19%)
test_handle_request📈 view plot
🚷 view threshold
131,110.00
(-5.88%)
149,986.10
(87.41%)
test_handle_request_jit📈 view plot
🚷 view threshold
96,653.00
(-13.01%)
149,579.85
(64.62%)
test_http_execute_method📈 view plot
🚷 view threshold
14,610.00
(+1.73%)
14,885.95
(98.15%)
with_mustache_expressions📈 view plot
🚷 view threshold
1,102.10
(-0.74%)
1,177.99
(93.56%)
with_mustache_literal📈 view plot
🚷 view threshold
699.25
(-1.73%)
763.35
(91.60%)
🐰 View full continuous benchmarking report in Bencher

Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 28, 2024
Copy link

github-actions bot commented Oct 8, 2024

PR closed after 10 days of inactivity.

@github-actions github-actions bot closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to set proxy in http and grpc directives
2 participants