-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update rust version #3043
base: main
Are you sure you want to change the base?
Conversation
impl IR { | ||
#[tracing::instrument(skip_all, fields(otel.name = %self), err)] | ||
pub fn eval<'a, 'b, Ctx>( | ||
&'a self, | ||
ctx: &'b mut EvalContext<'a, Ctx>, | ||
) -> impl Future<Output = Result<ConstValue, Error>> + Send + Captures<&'b &'a ()> | ||
) -> impl Future<Output = Result<ConstValue, Error>> + Send + use<'a, 'b, Ctx> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3043 +/- ##
==========================================
- Coverage 87.21% 87.10% -0.12%
==========================================
Files 280 280
Lines 27421 27234 -187
==========================================
- Hits 23916 23722 -194
- Misses 3505 3512 +7 ☔ View full report in Codecov by Sentry. |
- name: Install Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: "20.11.0" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the issue with wasm compatibility with new rust version. rustwasm/wasm-bindgen#4211 (comment)
might be worth to wait until the mentioned issue is resolved
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>