chore: update rust version #3043
Open
+40
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
meskill
commented
Oct 20, 2024
| impl IR { | ||
| #[tracing::instrument(skip_all, fields(otel.name = %self), err)] | ||
| pub fn eval<'a, 'b, Ctx>( | ||
| &'a self, | ||
| ctx: &'b mut EvalContext<'a, Ctx>, | ||
| ) -> impl Future<Output = Result<ConstValue, Error>> + Send + Captures<&'b &'a ()> | ||
| ) -> impl Future<Output = Result<ConstValue, Error>> + Send + use<'a, 'b, Ctx> |
There was a problem hiding this comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3043 +/- ##
==========================================
- Coverage 87.21% 87.10% -0.12%
==========================================
Files 280 280
Lines 27421 27234 -187
==========================================
- Hits 23916 23722 -194
- Misses 3505 3512 +7 ☔ View full report in Codecov by Sentry. |
Bencher Report
meskill
commented
Oct 26, 2024
Comment on lines
+78
to
+82
| - name: Install Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "20.11.0" | ||
|
|
There was a problem hiding this comment.
the issue with wasm compatibility with new rust version. rustwasm/wasm-bindgen#4211 (comment)
might be worth to wait until the mentioned issue is resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>