Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add checks for enterprise features #3200

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

laststylebender14
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 17.94872% with 64 lines in your changes missing coverage. Please review.

Project coverage is 86.25%. Comparing base (52d515c) to head (7287ed5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
tailcall-enterprise/src/enterprise.rs 24.56% 43 Missing ⚠️
src/cli/tc/start.rs 0.00% 9 Missing ⚠️
src/core/config/config_module.rs 0.00% 9 Missing ⚠️
src/core/config/directives/telemetry.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3200      +/-   ##
==========================================
- Coverage   86.44%   86.25%   -0.19%     
==========================================
  Files         282      283       +1     
  Lines       28756    28834      +78     
==========================================
+ Hits        24858    24872      +14     
- Misses       3898     3962      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath changed the title feat: add checks for enterprised features. feat: add checks for enterprise features Dec 5, 2024
Cargo.toml Outdated Show resolved Hide resolved
@laststylebender14 laststylebender14 marked this pull request as draft December 5, 2024 16:17
@laststylebender14
Copy link
Contributor Author

TODO's:

  1. update the configuration fetching URL.
  2. get the PR merged on keygen-rs.

src/cli/tc/start.rs Outdated Show resolved Hide resolved
@laststylebender14 laststylebender14 marked this pull request as ready for review December 6, 2024 14:03
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Dec 15, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants