-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tailcall Config Generator Form #388
Conversation
great work there @mehulmathur001 @Bhavyajain21, I had been working on this and was able to make the form very similar to yours using the same npm package, however I couldn't raise a PR as I had a few more things to do after setting up
it would be great if we could collaborate on this, and work towards a common goal, will be great experience working together. |
@hunxjunedo We have just raised a base PR currently and for moving forward we will require inputs from @tusharmath. Regarding the points you mentioned above, we also have tried out a few things like using tooltips by modifying templates. But after doing that we observed there's an inconsistency between the fields rendered, as rjsf treats each and every type of field differently. Hence removed tooltips part. Also, if we try to make it consistent by overriding everything then we'll be losing rjsf native form styles which look pretty decent to us. This is just a base PR and we're aware of the points you've raised. We wanted to raise a PR on the work we have done till now for progress. We have experimented a lot of things on this for making it better and we're still trying to figure out how can this be made more better, so don't take this up as the final UI 😄 |
Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention. |
@tusharmath Thanks for the review. We'll make the above changes. |
I have been looking at this project — https://www.youtube.com/watch?v=qV8Cho93oxU Check it out and see if we can leverage it in someway. The UI looks good. |
Sure @tusharmath |
Screen.Recording.2024-08-02.at.11.46.51.PM.mov |
@tusharmath, we have updated the form with the collapsible fields. Please have a look. |
Closing this PR for now. The UX needs a lot of work. Moving to draft. I will be posting the designs for this page via figma in a few days. |
/tip $100 For the attempt! |
🎉🎈 @mehulmathur001 has been awarded $100! 🎈🎊 |
@tusharmath, Me and @Bhavyajain21 have collaborated on this issue and would love your feedback on the form. Your input is essential for refining the layout and improving the user experience. Please review the changes and share your thoughts. Your feedback will help us ensure the best possible outcome.
/claim #373