Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tailcall Config Generator Form #388

Closed
wants to merge 51 commits into from

Conversation

mehulmathur001
Copy link
Contributor

@tusharmath, Me and @Bhavyajain21 have collaborated on this issue and would love your feedback on the form. Your input is essential for refining the layout and improving the user experience. Please review the changes and share your thoughts. Your feedback will help us ensure the best possible outcome.

/claim #373

@hunxjunedo
Copy link
Contributor

great work there @mehulmathur001 @Bhavyajain21, I had been working on this and was able to make the form very similar to yours using the same npm package, however I couldn't raise a PR as I had a few more things to do after setting up rjfs, which I see missing here as well:

  • options have a pretty bad UI by default, they show up as Option 1 and Option 2 which confuses the visitor, rather they should be like setup cache config. / leave cache config or stdout / otlp etc.
  • the current version doesn't export to GraphQL format as required.
  • glad that you guys noticed that long descriptions are making mess, however the code is commented out idk why
  • ajv is being used as a validator, which as far as I remember doesn't support formats like int64 uin32 etc.
  • the theme looks a bit off compared to the theme of the website, colors and margins need to be adjusted.
  • the form isn't properly integrated with the playground, it doesn't even appear unless the visitor scrolls down, this can be improved.
  • the UI for mobile has to be fine-tuned, it doesn't look alright as required (the info icon is added by me for testing):
    image
    image

it would be great if we could collaborate on this, and work towards a common goal, will be great experience working together.

@mehulmathur16
Copy link
Contributor

@hunxjunedo We have just raised a base PR currently and for moving forward we will require inputs from @tusharmath.

Regarding the points you mentioned above, we also have tried out a few things like using tooltips by modifying templates. But after doing that we observed there's an inconsistency between the fields rendered, as rjsf treats each and every type of field differently. Hence removed tooltips part. Also, if we try to make it consistent by overriding everything then we'll be losing rjsf native form styles which look pretty decent to us.

This is just a base PR and we're aware of the points you've raised. We wanted to raise a PR on the work we have done till now for progress. We have experimented a lot of things on this for making it better and we're still trying to figure out how can this be made more better, so don't take this up as the final UI 😄

@tusharmath
Copy link
Contributor

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

@tusharmath tusharmath marked this pull request as draft July 26, 2024 07:14
@mehulmathur16
Copy link
Contributor

@tusharmath Thanks for the review. We'll make the above changes.

@tusharmath
Copy link
Contributor

I have been looking at this project — https://www.youtube.com/watch?v=qV8Cho93oxU

Check it out and see if we can leverage it in someway. The UI looks good.

@mehulmathur16
Copy link
Contributor

Sure @tusharmath

@Bhavyajain21
Copy link
Contributor

Screen.Recording.2024-08-02.at.11.46.51.PM.mov

@Bhavyajain21
Copy link
Contributor

@tusharmath, we have updated the form with the collapsible fields. Please have a look.

@mehulmathur16 mehulmathur16 marked this pull request as ready for review August 2, 2024 18:33
@tusharmath tusharmath marked this pull request as draft August 11, 2024 10:53
@tusharmath
Copy link
Contributor

Closing this PR for now. The UX needs a lot of work. Moving to draft. I will be posting the designs for this page via figma in a few days.

@tusharmath tusharmath closed this Aug 11, 2024
@tusharmath
Copy link
Contributor

/tip $100

For the attempt!

Copy link

algora-pbc bot commented Aug 11, 2024

🎉🎈 @mehulmathur001 has been awarded $100! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants