Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build and run from Docker Support #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rajpratik71
Copy link

Build and run the generator from docker image support added.

The main aim and motivation behind doing this is, because
of a no. of different jhipster blueprints are there,
which are compatible and works with the different version of jhipster
and also might be incompatible with other blueprints or versions of jhipster.

Signed-off-by: Pratik Raj [email protected]

@yelhouti
Copy link
Contributor

yelhouti commented Jun 22, 2021

thanks for the PR, you know you can use --skip-checks which ignores the versions right ?

@Rajpratik71
Copy link
Author

thanks for the PR, you know you can use --skip-checks which ignores the versions right ?

I thought using that flag , but later i mached the version of jhipster

Build and run the generator from docker image support added.

The main aim and motivation behind doing this is, because
of a no. of different jhipster blueprints are there,
which are compatible and works with the different version of jhipster
and also might be incompatible with other blueprints or versions of jhipster.

Signed-off-by: Pratik Raj <[email protected]>
@Rajpratik71
Copy link
Author

thanks for the PR, you know you can use --skip-checks which ignores the versions right ?

Updated with flag

@yelhouti
Copy link
Contributor

what I meant is: why would you use a docker image if you could call one command with all the blueprints and --skip-checks

@Rajpratik71
Copy link
Author

Build and run the generator from docker image support added.

The main aim and motivation behind doing this is, because
of a no. of different jhipster blueprints are there,
which are compatible and works with the different version of jhipster
and also might be incompatible with other blueprints or versions of jhipster.

Signed-off-by: Pratik Raj [email protected]

This is the aim and reason to provide generator as docker image

@yelhouti
Copy link
Contributor

that is exactly my point, instead of having docker images, just call the genrator with --skip-checks isn't that much easier ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants