Ensure playgrounds work + switch to npm workspaces #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
fix/issue-2899
branch
from
9864e12 to
f4a6434
Compare
RobinMalfait
force-pushed
the
fix/issue-2899
branch
from
f4a6434 to
29032ab
Compare
|
LGTM 🚢 |
thecrypticace
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where changes to the package wasn't reflected when running the playground anymore.
For some reason, yarn v1 kept installing
@headlessui/reactas a package instead of using the workspace one. This means that the@headlessui/reactpackage used was coming from npm and changes to the@headlessui/reactpackage weren't used.When releasing insiders builds and normal releases we already used
npm workspacesinstead ofyarn workspaces. Switching completely tonpmsolved this issue as well.While moving to npm workspaces, I also moved
packages/playground-*toplaygrounds/*instead.Fixes: #2899