Add props for controlling close behavior of Dialog #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new props to
DialogcloseOnOutsideClick, defaults totrueto match current behavior but allows passingfalseto prevent closing the dialog when clicking outsidecloseOnEscape, defaults totrueto match current behavior but allows passingfalseto prevent closing the dialog when pressing the Escape keyThe other option I considered was to pass an argument to
onCloseindicating what action is causing the close. But this would be a backwards incompatible change, sinceonCloseis currently called withfalse. Possibly the reason could be the 2nd argument toonClose, so it would beonClose: (open: false, reason: "escape" | "click-outside")