feat: define constants for view types in MathPreviewPanel and PdfView…

…erPanel
tamuratak · Jan 24, 2025 · dafe7ae · dafe7ae
1 parent e5d3a7d
commit dafe7ae
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/components/mathpreviewpanel.ts b/src/components/mathpreviewpanel.ts
@@ -6,6 +6,8 @@ import { hasTexId } from '../utils/hastexid.js'
 import type { Logger } from './logger.js'
 
 
+export const mathPreviewPanelViewType = 'latex-toybox-mathpreview'
+
 interface UpdateEvent {
     type: 'selection',
     event: vscode.TextEditorSelectionChangeEvent
@@ -72,7 +74,7 @@ export class MathPreviewPanel {
     private findPanelTabs() {
         return vscode.window.tabGroups.all.flatMap(group =>
             group.tabs.filter(tab => {
-                return tab.input instanceof vscode.TabInputWebview && tab.input.viewType.includes('latex-toybox-mathpreview')
+                return tab.input instanceof vscode.TabInputWebview && tab.input.viewType.includes(mathPreviewPanelViewType)
             })
         )
     }
@@ -109,7 +111,7 @@ export class MathPreviewPanel {
         }
         this.mathPreview.getColor()
         const panel = vscode.window.createWebviewPanel(
-            'latex-toybox-mathpreview',
+            mathPreviewPanelViewType,
             'Math Preview',
             { viewColumn: vscode.ViewColumn.Active, preserveFocus: true },
             {

diff --git a/src/components/viewerlib/pdfviewerpanel.ts b/src/components/viewerlib/pdfviewerpanel.ts
@@ -12,6 +12,7 @@ import { Logger } from '../logger.js'
 import { Server } from '../server.js'
 import { inspectCompact } from '../../utils/inspect.js'
 
+export const pdfViewerPanelViewType = 'latex-toybox-pdf'
 
 export class PdfViewerPanel {
     readonly webviewPanel: vscode.WebviewPanel
@@ -129,7 +130,7 @@ export class PdfViewerPanelService {
 
     async createPdfViewerPanel(pdfFileUri: vscode.Uri, viewColumn: vscode.ViewColumn): Promise<PdfViewerPanel> {
         await this.extension.server.serverStarted
-        const panel = vscode.window.createWebviewPanel('latex-toybox-pdf', path.basename(pdfFileUri.path), viewColumn, {
+        const panel = vscode.window.createWebviewPanel(pdfViewerPanelViewType, path.basename(pdfFileUri.path), viewColumn, {
             enableScripts: true,
             retainContextWhenHidden: true
         })

diff --git a/src/providersmanager.ts b/src/providersmanager.ts
@@ -12,9 +12,10 @@ import { BibtexCompleter } from './providers/bibtexcompletion.js'
 import { FoldingProvider } from './providers/folding.js'
 import { BibtexFormatterProvider } from './providers/bibtexformatter.js'
 import type { Extension } from './main.js'
-import { MathPreviewPanelSerializer } from './components/mathpreviewpanel.js'
+import { MathPreviewPanelSerializer, mathPreviewPanelViewType } from './components/mathpreviewpanel.js'
 import { AtSuggestionCompleter } from './providers/atsuggestion.js'
 import { inspectCompact } from './utils/inspect.js'
+import { pdfViewerPanelViewType } from './components/viewerlib/pdfviewerpanel.js'
 
 
 abstract class SingleProviderManager implements vscode.Disposable {
@@ -149,9 +150,9 @@ export class ProvidersManager {
         )
 
         context.subscriptions.push(
-            vscode.window.registerWebviewPanelSerializer('latex-toybox-pdf', extension.viewer.pdfViewerPanelSerializer),
+            vscode.window.registerWebviewPanelSerializer(pdfViewerPanelViewType, extension.viewer.pdfViewerPanelSerializer),
             vscode.window.registerCustomEditorProvider('latex-toybox-pdf-hook', new PdfViewerHookProvider(extension), {supportsMultipleEditorsPerDocument: true}),
-            vscode.window.registerWebviewPanelSerializer('latex-toybox-mathpreview', new MathPreviewPanelSerializer(extension))
+            vscode.window.registerWebviewPanelSerializer(mathPreviewPanelViewType, new MathPreviewPanelSerializer(extension))
         )
 
         context.subscriptions.push(