Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Proposal Details Page to stats-dapp #1549

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

devpavan04
Copy link
Member

Summary of changes

  • Adds batched proposals details page to stats-dapp.

Proposed area of change

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

Screen Recording

CleanShot.2023-08-17.at.00.38.19.mp4

Note:

https://www.notion.so/hicommonwealth/Batched-Proposals-Stats-dApp-Subquery-49d9ac37b6194cb1a7956fd102076d1c

@devpavan04 devpavan04 added needs review 👓 Pull request needs a review statistics labels Aug 17, 2023
@devpavan04 devpavan04 self-assigned this Aug 17, 2023
@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for hubble-stats ready!

Name Link
🔨 Latest commit 9e04410
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/64ddcff5cbc8470008e0c33f
😎 Deploy Preview https://deploy-preview-1549--hubble-stats.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @devpavan04

Name Link
🔨 Latest commit 9e044109dc30023e27338a242dd8267686ed07e2
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/64ddd1db822d0c50e22e978c
😎 Deploy Preview https://64ddd1db822d0c50e22e978c--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍!

@AtelyPham AtelyPham merged commit 2a53278 into develop Aug 21, 2023
11 checks passed
@AtelyPham AtelyPham deleted the PS/add-proposal-batch-details-page branch August 21, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review 👓 Pull request needs a review statistics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Implement the batch proposal view for a given batch
2 participants