Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more favicons for different browser sizes #1717

Closed
wants to merge 4 commits into from
Closed

Conversation

drewstone
Copy link
Contributor

Summary of changes

Provide a detailed description of proposed changes.

  • Adds a lot of favicons

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for hubble-stats ready!

Name Link
🔨 Latest commit 4b7df3a
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/65168a78b6f848000949a1ac
😎 Deploy Preview https://deploy-preview-1717--hubble-stats.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @drewstone

Name Link
🔨 Latest commit 1d5c396875e6e4afb521f851c7d947636c1f33dd
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/65161a19d6bcc313345656b9
😎 Deploy Preview https://65161a19d6bcc313345656b9--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sizes of the favicons on Tangle Marketing and Tangle Stats are still different.

image

@drewstone
Copy link
Contributor Author

Ya I'm aware this didn't change it, we'd have to either get a bigger favicon or just not worry about this. CC @monaiuu maybe 16x16 isn't enough and we need 32x32, can you provide?

@github-actions
Copy link

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @drewstone

Name Link
🔨 Latest commit 4b7df3aafd23e046200f11726941b27979984e01
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/65168cc73a3a3550acf62d4e
😎 Deploy Preview https://65168cc73a3a3550acf62d4e--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@monaiuu
Copy link
Contributor

monaiuu commented Sep 29, 2023

Ya I'm aware this didn't change it, we'd have to either get a bigger favicon or just not worry about this. CC @monaiuu maybe 16x16 isn't enough and we need 32x32, can you provide?

It is because the margins are inconsistent using different images, device specification and favicon sizes should not matter. The correct favicon file can be accessed here: https://www.notion.so/hicommonwealth/Tangle-Logo-029bec068f1a4690a7defc92125be03d?pvs=4

We should remove all old favicon files for Tangle, and opt for the above image in Notion instead.

@drewstone drewstone closed this Sep 29, 2023
@AtelyPham AtelyPham deleted the drew/favicons branch October 16, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Update DKG stats favicon
3 participants