Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display DKG best authorities in authorities table #1815

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

devpavan04
Copy link
Member

Summary of changes

  • Optimizes useAuthorities and useAuthority hook which previously used to call useEffect every second. Now it is fixed by calling useEffect if new data in available.
  • Now authorities table in stats-dapp shows only the best authorities and not all the authorities.

Proposed area of change

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/tangle-dapp
  • apps/faucet
  • libs/webb-ui-components

Reference issue to close (if applicable)

Screen Recording

CleanShot.2023-11-02.at.14.04.34.mp4

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for hubble-stats ready!

Name Link
🔨 Latest commit e61d16f
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/6544107ecb693b0007fd6160
😎 Deploy Preview https://deploy-preview-1815--hubble-stats.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit e61d16f
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/6544107ef3c7790008c93335
😎 Deploy Preview https://deploy-preview-1815--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 2, 2023

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @devpavan04

Name Link
🔨 Latest commit e61d16f16c70c0807874793170a214da63d22b1f
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/654412949e57db66ba1df2f2
😎 Deploy Preview https://654412949e57db66ba1df2f2--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@devpavan04 devpavan04 merged commit 4a25c9f into develop Nov 2, 2023
16 checks passed
@devpavan04 devpavan04 deleted the PS/update-authority-table branch November 2, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dkg-stats-dapp needs review 👓 Pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Stats Dapp : Validators are displayed as DKG Authorities
2 participants