-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tangle-dapp): Integrate Blueprints APIs #2575
Conversation
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Depends on tangle-network/tangle#771. |
apyPercentage, | ||
// TODO: Find out a proper way to get the pool name, now it's the first token name | ||
// TODO: Find out a proper way to get the vault name, now it's the first token name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1xstj how to get the metadata name of the vault?
apiRx.query.services?.blueprints === undefined || | ||
apiRx.query.services?.operators === undefined | ||
) | ||
// TODO: Should return the error here instead of throw it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this TODO be handled as part of this PR? Seems important to also ensure that we don't hit 404 and instead just don't show certain content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drewstone I'm planning to modify the useApiRx
hook to be able to manage errors by returning them from functions like these briefly, when I do that I'll handle this TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AtelyPham In this specific case, since it's checking whether the pallets are available, if the feature isn't supported we should probably have an error state or at least default to 'empty,' since this is a possible edge case that the user would run into. For example, simply switching to mainnet (where the pallet(s) might not be live yet) would trigger this error to be thrown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this error occurs, the UI handles it by displaying a message to inform users that the feature is not supported.
Summary of changes
Provide a detailed description of proposed changes.
usePromise
hook.Pagination
component.Proposed area of change
Put an
x
in the boxes that apply.apps/bridge-dapp
apps/hubble-stats
apps/stats-dapp
apps/tangle-dapp
apps/testnet-leaderboard
apps/faucet
apps/zk-explorer
libs/webb-ui-components
Reference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g.
Closes #233
).Screen Recording
If possible provide a screen recording of proposed change.
CleanShot.2024-10-01.at.03.45.48.mp4