feat(tangle-dapp): Integrate Blueprints APIs #2575
Conversation
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Depends on tangle-network/tangle#771. |
| apyPercentage, | ||
| // TODO: Find out a proper way to get the pool name, now it's the first token name | ||
| // TODO: Find out a proper way to get the vault name, now it's the first token name |
There was a problem hiding this comment.
@1xstj how to get the metadata name of the vault?
| apiRx.query.services?.blueprints === undefined || | ||
| apiRx.query.services?.operators === undefined | ||
| ) | ||
| // TODO: Should return the error here instead of throw it |
There was a problem hiding this comment.
Will this TODO be handled as part of this PR? Seems important to also ensure that we don't hit 404 and instead just don't show certain content.
There was a problem hiding this comment.
@drewstone I'm planning to modify the useApiRx hook to be able to manage errors by returning them from functions like these briefly, when I do that I'll handle this TODO
There was a problem hiding this comment.
@AtelyPham In this specific case, since it's checking whether the pallets are available, if the feature isn't supported we should probably have an error state or at least default to 'empty,' since this is a possible edge case that the user would run into. For example, simply switching to mainnet (where the pallet(s) might not be live yet) would trigger this error to be thrown
There was a problem hiding this comment.
When this error occurs, the UI handles it by displaying a message to inform users that the feature is not supported.
Summary of changes
Provide a detailed description of proposed changes.
usePromisehook.Paginationcomponent.Proposed area of change
Put an
xin the boxes that apply.apps/bridge-dappapps/hubble-statsapps/stats-dappapps/tangle-dappapps/testnet-leaderboardapps/faucetapps/zk-explorerlibs/webb-ui-componentsReference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g.
Closes #233).Screen Recording
If possible provide a screen recording of proposed change.
CleanShot.2024-10-01.at.03.45.48.mp4