Not delete the server's working directory in Server:drop()
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochaplashkin
force-pushed
the
not-clean-vardir-by-param
branch
from
cf7febf to
fba6eb2
Compare
ochaplashkin
force-pushed
the
not-clean-vardir-by-param
branch
2 times, most recently
from
a252015 to
582b2d8
Compare
ochaplashkin
changed the title
--not-clean parameter and dont clean workdir--no-clean parameter and dont clean workdir
ylobankov
reviewed
Sep 13, 2023
ylobankov
reviewed
Sep 13, 2023
ochaplashkin
force-pushed
the
not-clean-vardir-by-param
branch
3 times, most recently
from
fcbdec7 to
42e5609
Compare
ylobankov
approved these changes
Sep 14, 2023
ochaplashkin
force-pushed
the
not-clean-vardir-by-param
branch
from
42e5609 to
4ec28ac
Compare
ylobankov
changed the title
--no-clean parameter and dont clean workdirServer:drop()
ylobankov
changed the title
Server:drop()Server:drop()
ochaplashkin
force-pushed
the
not-clean-vardir-by-param
branch
from
4ec28ac to
9cd23b3
Compare
Now, luatest does not delete the server's working directory in the drop() function. Instead of this, it deletes the whole var dir (default: /tmp/t) before running tests. So all server artifacts from all tests are saved after the run and can be analyzed. However, you can disable this deletion by specifying the new `--no-clean` option. Part of tarantool#308
ochaplashkin
force-pushed
the
not-clean-vardir-by-param
branch
from
9cd23b3 to
fd505dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, luatest does not delete the server's working directory in the
Server:drop()function. Instead of this, it deletes the whole var directory (default:/tmp/t) before running tests. So all server artifacts from all tests are saved after the run and can be analyzed.However, you can disable this deletion by specifying the new
--no-cleanoption.🟢 What's new in administration
--no-clean- new option to disable deletion of the var directory before running tests.Usage
Part of #308