Skip to content

Commit

Permalink
cd: remove attempt to print secrets to the log
Browse files Browse the repository at this point in the history
According to [1] printing secrets to the log is not a best practice.

From [1]:
  GitHub automatically redacts secrets printed to the log, but you
  should avoid printing secrets to the log intentionally.

[1] https://docs.github.com/en/actions/security-guides/encrypted-secrets#accessing-your-secrets
  • Loading branch information
LeonidVas committed Dec 1, 2022
1 parent b0c2020 commit 4fbdf80
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion .github/workflows/packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,18 @@ jobs:
-u ${RWS_AUTH} \
-F product=${PRODUCT_NAME}"
# We don't want to try to print secrets to the log, but we want
# to print a "curl" command to see what's going on.
CURL_CMD_ECHO="curl -LfsS \
-X PUT ${RWS_URL_PART}/${OS}/${DIST} \
-u *** \
-F product=${PRODUCT_NAME}"
for f in $(ls -I '*build*' -I '*.changes' ./build); do
CURL_CMD+=" -F $(basename ${f})=@./build/${f}"
CURL_CMD_ECHO+=" -F $(basename ${f})=@./build/${f}"
done
echo ${CURL_CMD}
echo ${CURL_CMD_ECHO}
${CURL_CMD}

0 comments on commit 4fbdf80

Please sign in to comment.