Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_iproto_port: remove duplicates #418

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

0x501D
Copy link
Member

@0x501D 0x501D commented Jan 23, 2024

In some tests, instances have duplicate file descriptors on one socket, which leads to abnormal termination of the test.

This patch removes duplicates to work around this problem.

In some tests, instances have duplicate file descriptors on one socket,
which leads to abnormal termination of the test.

This patch removes duplicates to work around this problem.
@0x501D 0x501D requested a review from Totktonada January 23, 2024 10:42
@coveralls
Copy link

Coverage Status

coverage: 62.479% (-0.03%) from 62.513%
when pulling 6f15e5d on 0x501D/fix-get_iproto_port
into bfcc9e8 on master.

@0x501D 0x501D requested a review from ylobankov January 23, 2024 10:46
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side.

@ylobankov ylobankov merged commit da98d7f into master Jan 24, 2024
9 checks passed
@ylobankov ylobankov deleted the 0x501D/fix-get_iproto_port branch January 24, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants