dispatcher: lift pipe buffer size restriction #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A task queue dispatcher puts all the tasks to the task queue at startup. Then workers are started and are taking the tasks from it. If there are many tasks in a task group (which roughly corresponds to a test suite), we can reach the pipe buffer size on putting into the queue, because `multiprocessing.SimpleQueue` uses a pipe under the hood. The solution is to use `multiprocessing.Queue`, which has an intermediate buffer before the underlying pipe and writes to the pipe in a background thread, without blocking a thread that calls `<queue>.put()`. The `Queue` API is a superset of the `SimpleQueue` API, so we can just replace the implementation. Let's also use `Queue` for the worker's output queue to be on the safe side and for consistency. Fixes #287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A task queue dispatcher puts all the tasks to the task queue at startup. Then workers are started and are taking the tasks from it.
If there are many tasks in a task group (which roughly corresponds to a test suite), we can reach the pipe buffer size on putting into the queue, because
multiprocessing.SimpleQueueuses a pipe under the hood.The solution is to use
multiprocessing.Queue, which has an intermediate buffer before the underlying pipe and writes to the pipe in a background thread, without blocking a thread that calls<queue>.put().The
QueueAPI is a superset of theSimpleQueueAPI, so we can just replace the implementation.Let's also use
Queuefor the worker's output queue to be on the safe side and for consistency.Fixes #287