Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dec: allow to save iterator to value instead of decoding #70

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

drewdzzz
Copy link
Collaborator

@drewdzzz drewdzzz commented Nov 22, 2023

The patch adds support of mpp::as_raw to new decoder. Wrapped value must be a pair of iterators (it can be wrapped to optional). When it is used, corresponding value is skipped but an iterator pointing to the value in buffer is saved. Also, one can pass pair<it_t, it_t> without as_raw tag.

NB: Encoder is not provided with pair<it_t, it_t> support in this patch - it will be later.

src/mpp/Dec.hpp Show resolved Hide resolved
src/mpp/Dec.hpp Show resolved Hide resolved
src/mpp/Dec.hpp Show resolved Hide resolved
src/mpp/Dec.hpp Outdated Show resolved Hide resolved
test/EncDecTest.cpp Outdated Show resolved Hide resolved
The trait allows to check if the type is a pair-like object, containing
objects of two particular types.
@drewdzzz drewdzzz force-pushed the new_raw branch 7 times, most recently from 391155c to a35a1b8 Compare November 28, 2023 15:10
@CuriousGeorgiy CuriousGeorgiy removed their assignment Nov 29, 2023
@drewdzzz drewdzzz requested a review from alyapunov November 29, 2023 14:02
The commit adds support of `mpp::as_raw` to new decoder. Wrapped value
must be a pair of iterators (it can be wrapped to optional). When
it is used, corresponding value is skipped but an iterator pointing to
the value in buffer is saved.
@alyapunov alyapunov merged commit b481eeb into tarantool:master Dec 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants