Dec: drop old decoder and dead code #91
Merged
+14
−1,766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old decoder is no longer suuported - let's remove it. There is 0.1.0 version of tntcxx for ones who want to use it.
The commit drops ObjHolder class and header because it was used by old decoder and is not used after its removal.
The commit drops ItrRange since it is not used in tntcxx.
The header is unused - let's remove it.
The commit drops the class and its header since they are not used.
drewdzzz
force-pushed
the
drop_old_decoder
branch
4 times, most recently
from
9080251 to
9446844
Compare
The helper is not used since it is trivial to decode data with new decoder, so let's drop it. Along the way, alias Buf_t is moved from TupleReader.hpp since it has nothing in common with tuple definition. Also, the header is renamed to UserTuple.hpp since it contains only tuple definition now. And, while we are here, headers in Client tests and UserTuple.hpp are sorted, linter warning are fixed.
drewdzzz
force-pushed
the
drop_old_decoder
branch
from
9446844 to
c3d1d8a
Compare
|
I don't know how to fix this FP in linter, so let's ignore it. |
drewdzzz
force-pushed
the
drop_old_decoder
branch
from
394141b to
adf1975
Compare
The header contains strerror definition used in this file. Along the way, the headers in System.hpp are sorted.
drewdzzz
force-pushed
the
drop_old_decoder
branch
from
adf1975 to
0006ca6
Compare
CuriousGeorgiy
approved these changes
Feb 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch drops the old decoder and entities that are not used after the removal.
Dead code that have nothing in common with decoder is dropped along the way.