build: fix linking when used in several translation units #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdzzz
force-pushed
the
fix_ld
branch
2 times, most recently
from
03f1b46 to
39b61fd
Compare
mkostoevr
reviewed
Oct 21, 2024
mkostoevr
reviewed
Oct 21, 2024
mkostoevr
approved these changes
Oct 21, 2024
CuriousGeorgiy
approved these changes
Nov 3, 2024
All non-template methods defined outside classes are not implicitly `inline` - that violates one definition rule when the connector is included in several translaction units. Let's mark such methods as `inline` to fix this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All non-template methods defined outside classes are not implicitly
inline- that violates one definition rule when the connector is included in several translaction units. Let's mark such methods asinlineto fix this issue.