test: re-enable async_no_yield test from vconnect test group
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have deadlock here, either Tarantool's integration tests fails with vshard or testing on master fails in vshard. PR should be merged right before tarantool/tarantool#9803 (review), backporting to 2.11 should be also done immediately. The other option is to delete |
Serpentian
reviewed
Mar 14, 2024
CuriousGeorgiy
force-pushed
the
gh-456-async-connect-yield
branch
from
47bd082 to
0ad7fec
Compare
Serpentian
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
If we'll go this way, we'll have failing CI for some time either in vshard on in master. The alternative of removing this test completely until the time, everything is merged is better IMO. @Gerold103, what do you think?
P.S. Failure of test_locate_master is caused by test_async_no_yield
After the fix for tarantool/tarantool#9489 bug was merged, we can now re-enable the test to reflect the correct behaviour in versions to which the fix was backported to. Closes tarantool#456 NO_DOC=<test>
CuriousGeorgiy
force-pushed
the
gh-456-async-connect-yield
branch
from
0ad7fec to
b28f63b
Compare
CuriousGeorgiy
changed the title
async_no_yield test from vconnect test groupasync_no_yield test from vconnect test group
Serpentian
approved these changes
Mar 21, 2024
Gerold103
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch re-enables the test to reflect the correct behavior after the fix for tarantool/tarantool#9489 bug was merged.
Closes #456