Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document prerequisites #1

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Document prerequisites #1

merged 1 commit into from
Jun 30, 2020

Conversation

hroederld
Copy link
Contributor

I wasted a bit of time getting the correct version of Locust, as the main package name has changed from locustio to locust and they went 1.0.0 since this was written, with the required version only available in the abandoned one. This adds a bit of doc pointing out the dependency. Also a little section on requirements.txt, I know essentially every project does that but hopefully it reduces support requests. This is otherwise incredibly easy and well documented!

@bwoskow-ld
Copy link

In addition to documenting the prerequisites, what would the effort be to move to 1.0.0?

@tarqd tarqd merged commit 45f2c72 into tarqd:master Jun 30, 2020
@tarqd
Copy link
Owner

tarqd commented Jun 30, 2020

@bwoskow-ld I've got a working PR for locust 1.0 but I haven't tested it too much: PR #4 . Works on my machine anyway :)
Besides replacing seq_task and renaming some classes/variables it looks like nothing important broke. I did have to uninstall the older version of locust on my machine because both packages wanted to be /usr/local/bin/locust

One gotcha I saw:
The class Locust was renamed to User and self.locust to self.user, which makes things a little uglier:

# gross
self.user.user

I changed the property to:

self.user.lduser

But I think that interface might need some refactoring for clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants