Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open threads #383

Merged
merged 12 commits into from
May 7, 2019
Merged

Open threads #383

merged 12 commits into from
May 7, 2019

Conversation

marcelomorgado
Copy link
Contributor

@marcelomorgado marcelomorgado commented May 7, 2019

Issue link

#369 (comment)
#369 (comment)
#369 (comment)
#369 (comment)
#367
#329

Auto-close the issue?

Closes #367

Types of changes

Bug fix (non-breaking change that fixes an issue)

Docs (modified documentation or code comments)

Technical debt (a code change that doesn't fix a bug or add a feature but makes something clearer for devs)

pcowgill
pcowgill previously approved these changes May 7, 2019
Copy link
Member

@pcowgill pcowgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcelomorgado Awesome work! Thanks!

packages/tasit-sdk/src/Decentraland.test.js Outdated Show resolved Hide resolved
packages/tasit-sdk/src/Decentraland.test.js Outdated Show resolved Hide resolved
@pcowgill
Copy link
Member

pcowgill commented May 7, 2019

A listener for "XYZ" isn't registered is being logged a lot in the tests now, FYI.

@marcelomorgado
Copy link
Contributor Author

A listener for "XYZ" isn't registered is being logged a lot in the tests now, FYI.

Extracted to: #385

@pcowgill
Copy link
Member

pcowgill commented May 7, 2019

A listener for "XYZ" isn't registered is being logged a lot in the tests now, FYI.

Extracted to: #385

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract event listeners aren't working properly
2 participants