Test reverting of CUDA installation on Windows staging #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemoore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the CUDA changes on Windows Staging (which seems to have broken Windows GPU pools in #830).
Note, this reverts it only from staging, so that we don't test in production (even though production GPU pools are probably broken, it is a good habit to get into).
It might be worth trying one last time to build with the CUDA installation on staging, or alternatively, we could revert on staging, and then use a pool where we run as root, get an RDP session on it, running as root, and see what is going wrong when we manually RDP onto it and execute the installation steps.
Weirdly, the installation seems to happen, but it seems to break the worker somehow, because workers were getting spawned, but not calling Worker Manager to get credentials, as far as I can tell.
At the same time, I enabled interactive on all worker pools in community, because I can't think of a good reason we would ever want to disable it. If that changes, we can set it at a worker pool level later, but for now, I think we should just keep things simple and have it enabled everywhere, until that becomes a problem.