Don't set root logger to INFO to avoid turning on all packages' logs #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small request! the line of code below sets the root logger's level to INFO. This causes INFO messages to be printed for every package that isn't manually set otherwise. This can be really noisy;
httpxwill for instance print a message for each request.Changing this here would mean INFO messages from alpaca are not printed by default; that's also Python's default.
If that's undesirable, and you're open to it, I can open a PR that routes all logging through an "alpaca_eval" logger that can be set to INFO individually.