-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
246 endpoint to update user #249
Conversation
@beblicarl, please you're needed here as well :) |
sure |
@itzgeebee , can you please work on the merge conflict |
Done @beblicarl |
awesome |
@itzgeebee , i pulled your branch and there's a lot of errors in your documentation. Kindly use |
alright I would do that |
@itzgeebee , i don't think there should be required fields in the schema if you want to update, what do you think? |
It wouldn't work otherwise. Since we are updating multiple fields, it's like we are adding a new user to the databases and if we don't make it required, the not null validation of the db would be triggered and it would throw an error. |
okayy |
@jocrah , i am done, kindly review |
thanks @beblicarl |
@jocrah I have made the changes |
@itzgeebee okay nice, taking a look |
nice one @itzgeebee 🚀 |
Thanks boss @jocrah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post-merge reviews haha, just documentation
Pre-Submission Checklist
main
branch.git commit --amend
to amend any fixes.Checklist:
What does this PR do?
This PR adds the functionality to update users
How should this be manually tested?