Fix: buffer overflow warning in python bindings

Signed-off-by: Jérémie Galarneau <[email protected]>
tbricks · Nov 12, 2017 · bbf3690 · bbf3690
1 parent b84ff46
commit bbf3690
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/extras/bindings/swig/python/lttng.i.in b/extras/bindings/swig/python/lttng.i.in
@@ -979,7 +979,7 @@ struct lttng_channel {
 	%extend {
 		char *__repr__() {
 			static char temp[512];
-			sprintf(temp, "lttng.Channel; name('%s'), enabled(%s)",
+			snprintf(temp, sizeof(temp), "lttng.Channel; name('%s'), enabled(%s)",
 				$self->name, $self->enabled ? "True" : "False");
 			return &temp[0];
 		}
@@ -994,8 +994,8 @@ struct lttng_session {
 
 	%extend {
 		char *__repr__() {
-			static char temp[512];
-			sprintf(temp, "lttng.Session; name('%s'), path('%s'), enabled(%s)",
+			static char temp[PATH_MAX + NAME_MAX + 512];
+			snprintf(temp, sizeof(temp), "lttng.Session; name('%s'), path('%s'), enabled(%s)",
 				$self->name, $self->path,
 				$self->enabled ? "True" : "False");
 			return &temp[0];