Normative: Allow locale based ignorePunctuation default #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"th" locale default ignorePunctuation to true instead of false so we need to get tht default value from the locale data instead of always false. Address #832
FrankYFTang
changed the title
anba
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
This looks reasonable to me from the spec point of view. I haven't yet investigated what needs to be changed implementation-wise, though.
One small nit: Annex A https://tc39.es/ecma402/#annex-implementation-dependent-behaviour should also be updated to include:
The default ignore punctuation value per locale (<xref> here)
ben-allen
approved these changes
Sep 11, 2023
Co-authored-by: Ben Allen <[email protected]>
|
Changed. PTAL |
|
LGTM! |
remove trailing space
7 tasks
FrankYFTang
added a commit
to FrankYFTang/test262
that referenced
this pull request
Sep 13, 2023
sffc
approved these changes
Sep 18, 2023
anba
approved these changes
Sep 28, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 5, 2023
…inor The default value for `GetOption` in `InitializeCollator` is changed from `false` to `undefined` to avoid having to `intl_isIgnorePunctuation` in the constructor function. The corresponding spec PR is <tc39/ecma402#833>, but our behaviour is already not strictly spec-compliant as described in <tc39/ecma402#832>, so it seems reasonable to simply implement the spec PR ahead of time. (We don't want to "fix" our implementation to strictly follow the spec without the PR, because that could be web-incompatible resp. at least disruptive for Thai users, which currently already get the expected behaviour where punctuation characters are ignored in Thai.) Differential Revision: https://phabricator.services.mozilla.com/D189545
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 6, 2023
…inor The default value for `GetOption` in `InitializeCollator` is changed from `false` to `undefined` to avoid having to `intl_isIgnorePunctuation` in the constructor function. The corresponding spec PR is <tc39/ecma402#833>, but our behaviour is already not strictly spec-compliant as described in <tc39/ecma402#832>, so it seems reasonable to simply implement the spec PR ahead of time. (We don't want to "fix" our implementation to strictly follow the spec without the PR, because that could be web-incompatible resp. at least disruptive for Thai users, which currently already get the expected behaviour where punctuation characters are ignored in Thai.) Differential Revision: https://phabricator.services.mozilla.com/D189545
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 8, 2023
…inor The default value for `GetOption` in `InitializeCollator` is changed from `false` to `undefined` to avoid having to `intl_isIgnorePunctuation` in the constructor function. The corresponding spec PR is <tc39/ecma402#833>, but our behaviour is already not strictly spec-compliant as described in <tc39/ecma402#832>, so it seems reasonable to simply implement the spec PR ahead of time. (We don't want to "fix" our implementation to strictly follow the spec without the PR, because that could be web-incompatible resp. at least disruptive for Thai users, which currently already get the expected behaviour where punctuation characters are ignored in Thai.) Differential Revision: https://phabricator.services.mozilla.com/D189545 UltraBlame original commit: bcf3b4652f995f4f52792d5897cd2d905d5a029f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 8, 2023
…inor The default value for `GetOption` in `InitializeCollator` is changed from `false` to `undefined` to avoid having to `intl_isIgnorePunctuation` in the constructor function. The corresponding spec PR is <tc39/ecma402#833>, but our behaviour is already not strictly spec-compliant as described in <tc39/ecma402#832>, so it seems reasonable to simply implement the spec PR ahead of time. (We don't want to "fix" our implementation to strictly follow the spec without the PR, because that could be web-incompatible resp. at least disruptive for Thai users, which currently already get the expected behaviour where punctuation characters are ignored in Thai.) Differential Revision: https://phabricator.services.mozilla.com/D189545 UltraBlame original commit: bcf3b4652f995f4f52792d5897cd2d905d5a029f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 8, 2023
…inor The default value for `GetOption` in `InitializeCollator` is changed from `false` to `undefined` to avoid having to `intl_isIgnorePunctuation` in the constructor function. The corresponding spec PR is <tc39/ecma402#833>, but our behaviour is already not strictly spec-compliant as described in <tc39/ecma402#832>, so it seems reasonable to simply implement the spec PR ahead of time. (We don't want to "fix" our implementation to strictly follow the spec without the PR, because that could be web-incompatible resp. at least disruptive for Thai users, which currently already get the expected behaviour where punctuation characters are ignored in Thai.) Differential Revision: https://phabricator.services.mozilla.com/D189545 UltraBlame original commit: bcf3b4652f995f4f52792d5897cd2d905d5a029f
|
This is on the agenda for discussion on 2024-02-06 TC39 meeting https://github.com/tc39/agendas/blob/main/2024/02.md |
FrankYFTang
added
has consensus
|
Has concensus from TG1 this morning around 11:25am PST (2024-02-06) |
|
Please merge |
ben-allen
added a commit
to ben-allen/mdn-content
that referenced
this pull request
Apr 30, 2024
Josh-Cena
added a commit
to mdn/content
that referenced
this pull request
Apr 30, 2024
…3338) * Update defaults for Intl.Collator's `ignorePunctuation` parameter to reflect tc39/ecma402#833 * Update files/en-us/web/javascript/reference/global_objects/intl/collator/collator/index.md --------- Co-authored-by: Joshua Chen <[email protected]>
ptomato
pushed a commit
to FrankYFTang/test262
that referenced
this pull request
Jun 27, 2024
ptomato
pushed a commit
to tc39/test262
that referenced
this pull request
Jun 27, 2024
…lt (#3922) * Add test for ECMA402 833 tc39/ecma402#833 * Update test/intl402/Collator/prototype/resolvedOptions/ignorePunctuation-default.js Co-authored-by: André Bargull <[email protected]> * Update test/intl402/Collator/prototype/resolvedOptions/ignorePunctuation-default.js Co-authored-by: André Bargull <[email protected]> --------- Co-authored-by: André Bargull <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"th" locale in CLDR collation rule default ignorePunctuation to true instead of false so we need to get tht default value from the locale data instead of always false.
Address #832
th CLDR rule is in
https://github.com/unicode-org/cldr/blob/main/common/collation/th.xml#L17
@anba @sffc @ben-allen @gibson042