Use the correct CLI option to enable TDZ in Hermes #138
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leotm
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
nice this worked perfectly earlier when eshost was running hermes cli 0.12.0 (HBC bytecode ver: 89) bin (from esvu/jsvu), i tested locally
➜ npm list -g
/Users/leo/.nvm/versions/node/v22.13.1/lib
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]
➜ sed -i '' 's|/Users/leo/.esvu/bin/hermes|/Users/leo/Documents/GitHub/hermes-cli-darwin-v0.12.0/hermes|g' /Users/leo/.eshost-config.json
➜ ls -l /Users/leo/.nvm/versions/node/v22.13.1/bin/eshost
lrwxr-xr-x@ 1 leo staff 44 31 Jan 13:37 /Users/leo/.nvm/versions/node/v22.13.1/bin/eshost -> ../lib/node_modules/eshost-cli/bin/eshost.js
➜ eshost -e "42"
#### engine262
42
#### hermes
hermes: Unknown command line argument '-fenable-tdz'. Try: '/Users/leo/Documents/GitHub/hermes-cli-darwin-v0.12.0/hermes -help'
#### javascriptcore
42
#### spidermonkey
42
#### v8
42
#### xs
42
➜ curl -o /Users/leo/.nvm/versions/node/v22.13.1/lib/node_modules/eshost-cli/node_modules/eshost/lib/agents/hermes.js https://raw.githubusercontent.com/tc39/eshost/58370fcbd7183cc5b10b9bd39b7173def13f5db3/lib/agents/hermes.js
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3047 100 3047 0 0 13840 0 --:--:-- --:--:-- --:--:-- 13850
➜ eshost -e "42"
#### engine262
42
#### hermes
42
#### javascriptcore
42
#### spidermonkey
42
#### v8
42
#### xs
42approved if we want to merge this first
but latest eshost pulls in the latest hermes cli 0.13.0 (HBC bytecode ver: 96) bin
where we currently still get similar error
➜ GitHub eshost -e "42"
#### engine262
42
#### hermes
hermes: Unknown command line argument '-Xenable-tdz'. Try: '/Users/leo/.esvu/bin/hermes -help'
#### javascriptcore
42
#### spidermonkey
42
#### v8
42
#### xs
42i've added a more simple/minimal fix here
leotm
suggested changes
Jan 31, 2025
Co-authored-by: LeoTM <[email protected]>
|
does the change look good @rwaldron? |
|
was about to fork till noticed 45 branches / 40 forks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125