Editorial: Make explicit that ToTemporalYearMonth rejects too-large ISO year strings #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the CreateISODateRecord call in ToTemporalYearMonth after processing the options to match the steps in ToTemporalMonthDay, ToTemporalDate, and ToTemporalDateTime.
…earMonth The call to `CalendarYearMonthFromFields` will already reject too large dates, but adding an explicit step makes it more obvious that `ISODateToFields` doesn't require support for mapping large ISO dates to calendar dates. And it also aligns `ToTemporalYearMonth` with `ToTemporalMonthDay` after #3054.
This change is not observable, but updating the reference code will help to confirm that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3083 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 21 21
Lines 9872 9874 +2
Branches 1800 1800
=======================================
+ Hits 9514 9516 +2
Misses 311 311
Partials 47 47 ☔ View full report in Codecov by Sentry. |
Ms2ger
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to CalendarYearMonthFromFields will already reject too large dates, but adding an explicit step makes it more obvious that ISODateToFields doesn't require support for mapping large ISO dates to calendar dates. And it also aligns ToTemporalYearMonth with ToTemporalMonthDay after #3054.
Taken from @anba's PR #3054, this is the editorial/unobservable part.