Add evaluation tests for import.defer with sync/async modules
#4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
38 tasks
15 tasks
nicolo-ribaudo
force-pushed
the
import-defer-dynamic-evaluation
branch
from
0badbd8 to
2c1404e
Compare
ptomato
reviewed
Jan 31, 2025
...age/expressions/dynamic-import/import-defer/sync-dependency-of-deferred-async-module/main.js
Outdated
Show resolved
Hide resolved
|
I tested these in the WebKit prototype and two of the tests found a bug in the implementation related to the async evaluation behavior. After fixing that bug, the tests pass on the prototype. LGTM modulo ptomato's comment above. |
|
Fixed! |
ptomato
force-pushed
the
import-defer-dynamic-evaluation
branch
from
45f3309 to
6bc9dc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last part of #4215 :)
Except for the test in the
syncfolder, the others are adaptations of the ones in https://github.com/tc39/test262/blob/main/test/language/import/import-defer/evaluation-top-level-await