Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED]Added validation for module. #444

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

deepti-50
Copy link
Contributor

Description

Used middleware validation service for validating ids and name of the module in controller/module.js file.

Fixes

Fixes #426

Checklist

  • Code follows project's style guidelines.
  • Changes are documented appropriately.

Copy link
Member

@TejasNair9977 TejasNair9977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sumitst05 sumitst05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes

controller/module.js Outdated Show resolved Hide resolved
controller/module.js Outdated Show resolved Hide resolved
controller/module.js Outdated Show resolved Hide resolved
@deepti-50
Copy link
Contributor Author

@sumitst05 please see whether the changes are done right.

Copy link
Contributor

@sumitst05 sumitst05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TejasNair9977 TejasNair9977 merged commit 81a3509 into development Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants