-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code for the Combiner role #15
Merged
Merged
Commits on Jan 31, 2024
-
Add two new macros and refactor the `combine` functions to use them. Refactor only, no logic changes.
Configuration menu - View commit details
-
Copy full SHA for d3125bd - Browse repository at this point
Copy the full SHA d3125bdView commit details -
v0: Fail to combine non-v0 PSBTs
It does not make sense to allow our `v0` implementation to combine two PSBTs with different versions, error if this is attempted. While we are at it, move the `CombineError` into `global` because that is where it originates. Although this is not important in `v0`, over in `v2` there will be different `CombineError`s for the different maps - lets be uniform already.
Configuration menu - View commit details
-
Copy full SHA for b598186 - Browse repository at this point
Copy the full SHA b598186View commit details -
Add a function `combine` to the `v0` module as we do in `v2`. While we are at it make all the docs and calling conventions uniform.
Configuration menu - View commit details
-
Copy full SHA for 2595bb7 - Browse repository at this point
Copy the full SHA 2595bb7View commit details -
v2: Fail to combine PSBTs with different global fields
If an attempt is made to combine two PSBTs with different values for the global map fields `version` or `tx_version` return an error. This is in line with what we did in `v0`.
Configuration menu - View commit details
-
Copy full SHA for 3c958a9 - Browse repository at this point
Copy the full SHA 3c958a9View commit details
Commits on Feb 1, 2024
-
v2: Correctly implement Input::combine
The current version of `Input::combine` is copied from the `v0` module and is not correct for `v2` - fix it.
Configuration menu - View commit details
-
Copy full SHA for 162730c - Browse repository at this point
Copy the full SHA 162730cView commit details -
As we did in other places use plural form for fields in the `Output` map.
Configuration menu - View commit details
-
Copy full SHA for 8362792 - Browse repository at this point
Copy the full SHA 8362792View commit details -
v2: Correctly implement Output::combine
As we did for `v2::Input`. The current version of `Output::combine` is copied from the `v0` module and is not correct for `v2` - fix it.
Configuration menu - View commit details
-
Copy full SHA for 6d6ee6c - Browse repository at this point
Copy the full SHA 6d6ee6cView commit details -
We have now fully replaced the usage of this private macro, remove it.
Configuration menu - View commit details
-
Copy full SHA for c0ce672 - Browse repository at this point
Copy the full SHA c0ce672View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.