Upgrade compatibility for Python 3 and adding some API list methods + Travis CI with code coverage #2
Conversation
|
Can you squash the 10 travis support commits into 1, or use better commit descriptions?! |
| configobj>=5.0.2 | ||
| #xmlrpc |
There was a problem hiding this comment.
I was young and dumb when I created this set of requirements. You can remove anything that's commented out and please specify versions here for safety's sake.
There was a problem hiding this comment.
OTOH, it looks like some of this stuff is needed for Python 2.
There was a problem hiding this comment.
Good stuff :-) Opt. --system for me it's the best
I can developing/releasing/verifing independently from my webfaction's account, by my own deployment tool written in Python.
webfaction/webflib.py
Outdated
| from configobj import ConfigObj | ||
| try: | ||
| from configobj import ConfigObj | ||
| except: |
There was a problem hiding this comment.
This should only catch ImportError.
webfaction/webflib.py
Outdated
| ''' | ||
| #XXX: Validate db_type | ||
| """ | ||
| # TODO: Validate db_type |
There was a problem hiding this comment.
assert db_type in ["mysql", "postgres"], "Invalid db_type %s" % db_type
| if https.lower() == 'true': | ||
| https = True | ||
| else: | ||
| https = False | ||
| subdomains = subdomains.split(',') | ||
| print subdomains | ||
| #XXX: Limitation of only one site_app | ||
| print(subdomains) |
There was a problem hiding this comment.
Ideally we would move the print statements to logging, but it's a cli, so . . .
|
Few small things, but looks like a great improvement. Thanks! |
bieli
changed the title
|
|
||
| __version__ = '1.0' | ||
| __version__ = '1.1' |
There was a problem hiding this comment.
@bieli you should add yourself to __contributors__ as well!
No description provided.