Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes optional #801

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

alerosmile
Copy link
Contributor

Closes #799

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (92fee05) to head (24fa197).
Report is 157 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/vafer/jdeb/DebMaker.java 73.33% 0 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #801      +/-   ##
============================================
+ Coverage     71.03%   72.38%   +1.35%     
- Complexity       96      112      +16     
============================================
  Files             7        8       +1     
  Lines           580      612      +32     
  Branches         75       81       +6     
============================================
+ Hits            412      443      +31     
+ Misses          121      118       -3     
- Partials         47       51       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcurdt
Copy link
Owner

tcurdt commented Jan 7, 2025

Looking good. Thanks!

Any chance to improve the test coverage a little? It has dropped below the threshold.

@alerosmile
Copy link
Contributor Author

Regarding the coverage: it's difficult to interpret the reports because the base commit is almost a year old. Shouldn't that always be the base commit of the feature branch? And it's hard to believe that my PR introduces new uncovered lines since it just disables execution of some code. The lines the report is complaining about haven't been covered before and were introduced a long time ago. And it also seems that only a subset of the project is included in the reports (see https://app.codecov.io/gh/tcurdt/jdeb)

Nevertheless I wrote a test to cover that region.

@tcurdt
Copy link
Owner

tcurdt commented Jan 8, 2025

TBH - I didn't even check. It's just that the integration broke the pipeline.

I suspect the area was just really close to the tipping point.
Then a single added or removed branch can make a difference. Anyway!

Thank you so much!

@tcurdt tcurdt merged commit 324195a into tcurdt:master Jan 8, 2025
7 checks passed
@alerosmile alerosmile deleted the make-changes-optional branch January 8, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven plugin fails if changesOut is set and points to a directory which doesn't exist
3 participants