Skip to content

Commit

Permalink
fix: navigation 로고
Browse files Browse the repository at this point in the history
  • Loading branch information
Josanghyeon authored and Josanghyeon committed Dec 28, 2022
1 parent dbc7662 commit 765f908
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 13 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"prettier": "^2.7.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-router-dom": "^6.4.4",
"react-router-dom": "^6.6.1",
"semantic-release": "^19.0.5",
"styled-components": "^5.3.6",
"ts-loader": "^9.4.1",
Expand Down
4 changes: 2 additions & 2 deletions src/components/logo/Horizontal.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
interface PropsType {
width: number;
height: number;
width?: number;
height?: number;
}

export const Horizontal = ({ width = 707, height = 254 }: PropsType) => (
Expand Down
4 changes: 2 additions & 2 deletions src/components/logo/Vertical.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
interface PropsType {
width: number;
height: number;
width?: number;
height?: number;
}

export const Vertical = ({ width = 458, height = 556 }: PropsType) => (
Expand Down
4 changes: 2 additions & 2 deletions src/components/logo/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import { Vertical } from './Vertical';

interface PropsType extends marginCssType {
type: 'horizontal' | 'vertical';
width: number;
height: number;
width?: number;
height?: number;
}

export const Logo = ({ type, margin, width, height }: PropsType) => {
Expand Down
10 changes: 7 additions & 3 deletions src/components/navigatorBar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { ArchiveBox } from '../styleGuide/icon/ArchiveBox';
import { Human } from '../styleGuide/icon/Human';
import { Text } from '../styleGuide/text/Text';
import { Item } from './Item';
import { Logo } from '../logo';

type NavListType = '홈' | '신청' | '공지' | '설문' | '분실물' | '마이페이지';

Expand All @@ -18,9 +19,12 @@ export const NavigatorBar = ({ navList }: PropsType) => {
return (
<_Filler>
<_Navigation>
<Text margin={['bottom', 30]} size="headlineL" color="primary">
DMS
</Text>
<Logo
margin={['bottom', 48]}
width={113}
height={40}
type="horizontal"
/>
{navList.map((name, idx) => {
const { Icon, link } = nameToIconLink[name];
return <Item key={idx} name={name} Icon={Icon} link={link} />;
Expand Down
5 changes: 2 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3906,7 +3906,7 @@ __metadata:
react: ^18.2.0
react-dom: ^18.2.0
react-outside-click-handler: ^1.3.0
react-router-dom: ^6.4.4
react-router-dom: ^6.6.1
semantic-release: ^19.0.5
styled-components: ^5.3.6
ts-loader: ^9.4.1
Expand All @@ -3917,7 +3917,6 @@ __metadata:
peerDependencies:
react: ">= 18"
react-dom: ">= 18"
react-router-dom: ">= 6"
styled-components: ">= 5"
languageName: unknown
linkType: soft
Expand Down Expand Up @@ -14886,7 +14885,7 @@ __metadata:
languageName: node
linkType: hard

"react-router-dom@npm:^6.4.4":
"react-router-dom@npm:^6.6.1":
version: 6.6.1
resolution: "react-router-dom@npm:6.6.1"
dependencies:
Expand Down

0 comments on commit 765f908

Please sign in to comment.