Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package.swift #126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gevorgyanvahagn
Copy link

WEBRTC-XXX - Ticket title

Please provide a summary of the change / issue with a proper context.

👴 👶 Behaviors

Before changes

  • The info.plist was included in the Package.swift file, causing Xcode to throw the following error:
    "public headers ("include") directory path for 'TelnyxRTC' is invalid or not contained in the target"
  • This error prevented the SPM package from resolving/loading correctly.

After changes

  • The info.plist has been excluded from the Package.swift file.
  • Manually tested and confirmed that the package resolves without an error now.
  • Xcode no longer throws the "public headers ("include") directory path for 'TelnyxRTC' is invalid or not contained in the target" error.

TODO

No pending items.

✋ Manual testing

  1. Open the project in Xcode.
  2. Ensure that the info.plist is not included in the Package.swift file.
  3. Build the project.
  4. Verify that the package resolves without any errors.
  5. Confirm that the SPM packages are loading correctly.

Known Issues

No known issues.

Screenshots

Screenshot 2024-06-29 at 21 36 36

@gevorgyanvahagn
Copy link
Author

I opened this PR three days ago to fix the SPM package issue in the latest SDK release. Is there any update on when it might be reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant