Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#53) ์ž๋ฐ” ๋ฒ„์ „ ๋ณ€๊ฒฝ ๋ฐ CI ์„ค์ • #54

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

๐Ÿ”€ :: (#53) ์ž๋ฐ” ๋ฒ„์ „ ๋ณ€๊ฒฝ ๋ฐ CI ์„ค์ • #54

wants to merge 5 commits into from
+144 โˆ’165

Conversation

jaemin05
Copy link
Member

close #53

@jaemin05 jaemin05 added the ํ”„๋กœ์ ํŠธ ์„ค์ • ํ”„๋กœ์ ํŠธ ์„ค์ •์ด ํ•„์š”ํ•จ์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค. label Jan 28, 2023
@jaemin05 jaemin05 self-assigned this Jan 28, 2023
@xquare-admin
Copy link

P1: ๊ผญ ๋ฐ˜์˜ํ•ด์ฃผ์„ธ์š” (Request changes)
P2: ์ ๊ทน์ ์œผ๋กœ ๊ณ ๋ คํ•ด์ฃผ์„ธ์š” (Request changes)
P3: ์›ฌ๋งŒํ•˜๋ฉด ๋ฐ˜์˜ํ•ด ์ฃผ์„ธ์š” (Comment)
P4: ๋ฐ˜์˜ํ•ด๋„ ์ข‹๊ณ  ๋„˜์–ด๊ฐ€๋„ ์ข‹์Šต๋‹ˆ๋‹ค (Approve)
P5: ๊ทธ๋ƒฅ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค (Approve)
์งˆ๋ฌธ์€ ๊ทธ๋ƒฅ ์ฝ”๋ฉ˜ํŠธ๋กœ ๐Ÿ˜ƒ

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!ย  ย  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaemin05 jaemin05 requested a review from eogus2513 January 30, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhhong0509 jhhong0509 Awaiting requested review from jhhong0509

@jeongjiwoo0522 jeongjiwoo0522 Awaiting requested review from jeongjiwoo0522

@lyutvs lyutvs Awaiting requested review from lyutvs

@oliver37632 oliver37632 Awaiting requested review from oliver37632

@leeseojune53 leeseojune53 Awaiting requested review from leeseojune53

@eogus2513 eogus2513 Awaiting requested review from eogus2513

At least 1 approving review is required to merge this pull request.

Assignees

@jaemin05 jaemin05

Labels
ํ”„๋กœ์ ํŠธ ์„ค์ • ํ”„๋กœ์ ํŠธ ์„ค์ •์ด ํ•„์š”ํ•จ์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

์ž๋ฐ” ๋ฒ„์ „ ๋ณ€๊ฒฝ
3 participants
@jaemin05 @xquare-admin @eogus2513