Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feat s3 endpoint #75

Closed
wants to merge 0 commits into from
Closed

WIP: Feat s3 endpoint #75

wants to merge 0 commits into from

Conversation

kingdonb
Copy link
Member

Supporting changes for teamhephy/postgres#6

Perhaps the default setting should remain as "true"?

These commits may still need to be cleaned up so they conform to the style guide...

@yebyen
Copy link

yebyen commented Nov 24, 2018

So, I also hit a catch-22 while I was testing this...

There was something that required me to set an endpoint, so I set "sfo2" since I noticed a piece of the database backup code which would use region to inform "create_bucket" -- I have no idea if this will work against the DigitalOcean API, I had already created the buckets, but this seemed to fit.

Then I tried builder, and noticed:

2018/11/24 19:14:21 Invalid region provided: sfo2
remote: 2018/11/24 19:14:26 Error running git receive hook [build pod exited with code 1, stopping build]
To ssh://hephy.rocks:30075/rocksolidapp.git
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'ssh://[email protected]:30075/rocksolidapp.git'

Maybe it would work if I was able to set an empty region, but like I said, something else had prohibited me from leaving the region value blank. Will follow up later...

@yebyen
Copy link

yebyen commented Nov 24, 2018

I also noticed, with regard to DO and kops, that having configured ingress, I still had a LoadBalancer provisioned by deis-builder, which was expected; but it never picked up the backing service and routed traffic to it. I don't know if this would have worked with the managed Kubernetes service, I assume so. Kops support for DigitalOcean is alpha, but "Limited release" managed k8s probably has this solved already.

This is why as you can see I kicked builder over into NodePort mode for the purposes of this testing. I had to do this by hand; I guess that the router nodeport setting is not apparently able to be honored as well by builder in ingress mode.

@duanhongyi
Copy link
Member

duanhongyi commented Nov 25, 2018

I have close my rp(#74) and sorted out the commit log, removed global var, and submitted a new RP.

see:
#76 (Including all commits of this RP, only modifying global variables to local variables)
teamhephy/postgres#7

@kingdonb
Copy link
Member Author

kingdonb commented Feb 14, 2019

This was not closed on purpose... whoops – it looks like #76 is still open though, so this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants