Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Boxcryptor references #343

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

karantan
Copy link
Member

We are not using it anymore.

We are not using it anymore.
@@ -6,7 +6,7 @@ Instead of lengthy and often biased per-person negotiations, Niteo uses a Salary

We've done a lot of research before creating a system that works for us and big thanks go to companies who publish details about their own Salary Systems. These include [Basecamp](https://m.signalvnoise.com/how-we-pay-people-at-basecamp/), [Travis CI](https://www.youtube.com/watch?v=N8u9H6JDAzo), [Buffer](https://buffer.com/salary/data-scientist-2/average/), and others. We hope that by publishing ours, we inspire other companies to do the same.

Salary System is a constant work in progress and we always strive to make it better and more fair for everyone in the company. The spreadsheet with all the data and calculations is available on `Boxcryptor/Niteans/5_People/Salary System`.
Salary System is a constant work in progress and we always strive to make it better and more fair for everyone in the company. The spreadsheet with all the data and calculations is available on `Dropbox/Niteans/5_People/Salary System`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zupo 2023 file needs to be included. There are only 2019 and 2020 files there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was manual back then. It's in Scrooge and Salary Calculator now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already calculated values in the Salary Calculator(https://github.com/teamniteo/salarycalc/blob/main/config.yml). The spreadsheet clearly shows how each base salary is calculated. I believe that this is important for every Nitean, especially newcomers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karantan How is that better than this?

Screenshot 2024-01-25 at 18 11 11

Copy link
Member Author

@karantan karantan Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This calculation is wrong because the commitment bonus is rounded. Also, values from salary.com are changing on a daily basis so it is really hard to reverse engineer the logic without really looking into the code and understanding what exactly it's doing.
I was able to do this and confirmed that everything is correct. IMO if we have an open system I think every Nitean should need to be able to confirm that their calculation is correct, without looking at the code.

I don't think this is a lot of work. We need screenshots from salary.com graphs (so that we have a trace of which values have we taken for the base salary) and some sort of a .log file where the steps for the calculations are logged. Something like those robot files, except the content will be about calculation.

Before we do this we can also make an experiment and ask every nitean if they know how their salary is calculated manually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be strongly against adding another view, like the spreadsheet. The calculator is what needs to be readable, understandable and replicable. If it's not right now, we should definitely do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Trace of values -> we have commits in the Salary Calc repo, so we do have a trace or log of changes. Would adding "as of " next to "(base salary)" help?

  2. rounding of commitment bonus -> it should be easy to remove the rounding from the Elm view code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trace of values -> we have commits in the Salary Calc repo, so we do have a trace or log of changes. Would adding "as of " next to "(base salary)" help?

IMO yes.

rounding of commitment bonus -> it should be easy to remove the rounding from the Elm view code

IMO, this needs to be done because it looks like a bug if you don't know how the program works.

@dmurko dmurko merged commit 2cfaac7 into main Jan 24, 2024
2 checks passed
zupo added a commit to teamniteo/salarycalc that referenced this pull request Feb 6, 2024
zupo added a commit to teamniteo/salarycalc that referenced this pull request Feb 6, 2024
easier to verify that the salary is being calculated correctly.

Refs teamniteo/handbook#343 (comment)
zupo added a commit to teamniteo/salarycalc that referenced this pull request Feb 6, 2024
zupo added a commit to teamniteo/salarycalc that referenced this pull request Feb 6, 2024
easier to verify that the salary is being calculated correctly.

Refs teamniteo/handbook#343 (comment)
zupo added a commit to teamniteo/salarycalc that referenced this pull request Feb 7, 2024
zupo added a commit to teamniteo/salarycalc that referenced this pull request Feb 7, 2024
easier to verify that the salary is being calculated correctly.

Refs teamniteo/handbook#343 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants