Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/#324] 바텀바, 달력 / 3차 스프린트 QA 반영 #325

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

boiledEgg-s
Copy link
Member

⛳️ Work Description

  • 달력 화면 진입시 상태 초기화
  • 바텀바 마이페이지 라이팅 수정
  • 미사용 라이브러리 삭제

📸 Screenshot

바텀바 수정 달력상태 관리
250107_.mp4

📢 To Reviewers

  • 바텀바를 수정하면서 패키지 위치도 옮겨버렸습니다! 이유는 프리뷰와 주석 작성인데, MainScreen 안에 있으니까 두 개를 작성하는게 지저분하더라구요,,
  • 그림자를 1.dp를 적용했을 땐 그냥 줄 하나 그어놓은 것 같아서 2.dp로 설정했습니다!
  • 홈화면 상태 관리도 알아보려고 했는데, Paging이 통신마다 새로운 flow를 받아오는 구조라 페이지 위치를 보존하기엔 어려울 것 같아서 일단 안건드렸습니다!

@boiledEgg-s boiledEgg-s added FIX 🔨 버그 및 오류 해결 석준💜 석준 labels Jan 6, 2025
@boiledEgg-s boiledEgg-s self-assigned this Jan 6, 2025
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정사항 확인했습니당~~

Comment on lines +71 to +75
DisposableEffect(true) {
onDispose {
viewModel.resetUiState()
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 대견한 석준씨...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대견한 석준씨...

Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~~!!

Comment on lines +71 to +75
DisposableEffect(true) {
onDispose {
viewModel.resetUiState()
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대견한 석준씨...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 아예 컴포넌트로 분리하셨네요!! 굿굿

@boiledEgg-s boiledEgg-s merged commit f51f632 into develop Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX 🔨 버그 및 오류 해결 석준💜 석준
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 바텀바, 달력 / 3차 스프린트 QA 반영
3 participants