Diversos Cambios #19
Open
Diversos Cambios #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaitan
reviewed
Nov 4, 2016
| {% block body %} | ||
|
|
||
|
|
||
| <html> |
There was a problem hiding this comment.
esto está MAL. lo probaron en el navegador? como se ve?
adentro del bloque body solo va el contenido es decir, en este caso, el form y todo lo que hemos puesto dentro de la etiqueta <body>. todo lo que está afuera de eso se "hereda" del templeta del cual se extá extendiendo. en este caso 'login.html'
esto estaria generando un bloque html dentro de otro.
There was a problem hiding this comment.
Ese es un archivo en el que yo iba copiando y pegando codigo para probarlo..lo subi por error..
mgaitan
reviewed
Nov 4, 2016
| if form.is_valid(): | ||
| paciente= Paciente.objects.filter(apellido__icontains=form.cleaned_data['busqueda']) | ||
|
|
||
| else: |
There was a problem hiding this comment.
este else no debe ir al nivel del is_valid sino al nivel de request.method. sino para el caso de que sea un GET no va a estar definido el form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estos son algunos cambios que faltaban sobre el buscador