Support system.model-name hardware requirement for mrack

[skycastlelily]

Pull Request Checklist

• implement the feature
• write the documentation
• extend the test coverage
• update the specification
• adjust plugin docstring
• modify the json schema
• mention the version
• include a release note

[skycastlelily]

Ah,yeah😅, thanks for your review,and updated:)

…

On Tue, Oct 22, 2024 at 8:06 PM Filip Vágner ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tmt/steps/provision/mrack.py <#3280 (comment)>: > @@ -567,6 +567,23 @@ def _transform_system_numa_nodes( children=[MrackHWBinOp('numanodes', beaker_operator, actual_value)]) +def _transform_system_model_name( + constraint: tmt.hardware.NumberConstraint, Shouldn't it be TextConstraint? ⬇️ Suggested change - constraint: tmt.hardware.NumberConstraint, + constraint: tmt.hardware.TextConstraint, — Reply to this email directly, view it on GitHub <#3280 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23B63KNOISDCB73G32LZ4Y5STAVCNFSM6AAAAABPYDKSW6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBUHE4TGNRWHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[therazix]

@skycastlelily I believe you accidentally edited the _transform_cpu_model function. I meant changing the NumberConstraint to TextConstraint in the _transform_system_model_name function.

[skycastlelily]

ah,yes😅,thanks a lot for pointing that out,updated,should be good now:)

…

On Thu, Oct 24, 2024 at 7:40 PM Filip Vágner ***@***.***> wrote: @skycastlelily <https://github.com/skycastlelily> I believe you accidentally edited the _transform_cpu_model function. I meant changing the NumberConstraint to TextConstraint in the _transform_system_model_name function. — Reply to this email directly, view it on GitHub <#3280 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23DH5LUD73VEX6SXFSDZ5DMDFAVCNFSM6AAAAABPYDKSW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVGA2DANZYGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>