FileConventions: fix empty string false-positives

Fix `DefiningEmptyStringsWithDoubleQuotes()` function by using regex insted of `Contains()`. Co-authored-by: Parham <[email protected]>
tehraninasab · Aug 29, 2023 · f4ca0ca · f4ca0ca
1 parent 32eeacb
commit f4ca0ca
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/FileConventions/Library.fs b/src/FileConventions/Library.fs
@@ -406,7 +406,9 @@ let IsExecutable(fileInfo: FileInfo) =
 
 let DefiningEmptyStringsWithDoubleQuotes(fileInfo: FileInfo) =
     let fileText = File.ReadAllText fileInfo.FullName
-    fileText.Contains "\"\""
+
+    Regex("(?<!\\\\)(?<!\\|\\s*)\"\"", RegexOptions.Compiled)
+        .IsMatch fileText
 
 let ProjFilesNamingConvention(fileInfo: FileInfo) =
     let regex = Regex "(.*)\..*proj$"